search

hyperium / tonic

A native gRPC client & server implementation with async/await support.
https://docs.rs/tonic
MIT License
9.46k stars 971 forks source link

build: add removed `prost_build::{Service, Method}` trait implementations #1785

Closed mbrobbel closed 1 week ago

mbrobbel commented 2 weeks ago

Motivation

1599 removed the tonic_build::Service and tonic_build::Method

implementations for prost_build::Service and prost_build::Method. These impls are used in https://github.com/neoeinstein/protoc-gen-prost.

Solution

This PR re-adds the implementations that were removed in #1599.

neoeinstein commented 1 week ago

It's possible that this may not be required inside of Tonic, and we can instead use the new-type pattern inside of protoc-gen-tonic to do this ourselves instead. I'll take a look, and if so, that will encourage the pattern of having implementers provide their own values.

mbrobbel commented 1 week ago

Closing as this is indeed not needed.