search

hyperium / tonic

A native gRPC client & server implementation with async/await support.
https://docs.rs/tonic
MIT License
9.72k stars 992 forks source link

`.proto` files are licensed under `Apache-2.0` #1939

Open LecrisUT opened 6 days ago

LecrisUT commented 6 days ago

The main project is licensed under MIT, but it seems to contain Apache-2.0 licensed files as well. Shouldn't the Cargo.toml file reflect that?

Additionally the generated files like types.bin have embedded BSD-3-Clause license text.

LecrisUT commented 4 days ago

I received some advice from fellow fedora rust packagers about packaging these crates. The main suggestion is to move codegen to a build.rs in each relevant crate. There isn't a circular dependency that would block this, and this would guarantee that the generated files are always up-to-date. The main concern is about types.bin being rather obscure, and on Fedora side we should be re-generating the code, which would be difficult if these are in the workspace. Would that be ok with you?

Another uncertain question we have is with the inclusion of BSD-3-Clause license which seems to be from protobuf files, and we are not sure if the license in Cargo.toml should reflect the source code or the artifacts. At the very least though, the Apache-2.0 license need to be included