hyperjump-io / json-schema

JSON Schema Validation, Annotation, and Bundling. Supports Draft 04, 06, 07, 2019-09, 2020-12, OpenAPI 3.0, and OpenAPI 3.1
https://json-schema.hyperjump.io/
MIT License
224 stars 21 forks source link

`just-curry-it` is not a declared dependency of `@hyperjump/json-schema` in latest version #25

Closed bryce-carson closed 1 year ago

bryce-carson commented 1 year ago

https://github.com/hyperjump-io/json-schema/blob/0cef4969ef475ce6877eb6da4052e480fa144f2f/lib/schema.js#LL1C35-L1C35

While transpiling with Parcel, I found that while Pact declares the dependnecy on just-curry-it, this downstream package does not.

🚨 Build failed.

@parcel/core: Failed to resolve 'just-curry-it' from 
'/home/vovgiobt/nodevenv/public_html/blog-backend.cyberscientist.ca/14/lib/node_modules/@hyperjump/json-schema/lib/schema.js'

  /home/vovgiobt/nodevenv/public_html/blog-backend.cyberscientist.ca/14/lib/node_modules/@hyperjump/json-schema/lib/schema.js:1:19
  > 1 | import curry from "just-curry-it";
  >   |                   ^^^^^^^^^^^^^^^
    2 | import * as Pact from "@hyperjump/pact";
    3 | import { nil as nilPointer, append as pointerAppend, get as pointerGet } from "@hyperjump/json-pointer";

@parcel/resolver-default: External dependency "just-curry-it" is not declared in package.json.

  /home/vovgiobt/nodevenv/public_html/blog-backend.cyberscientist.ca/14/lib/node_modules/@hyperjump/json-schema/package.json:37:3
    36 |   "bundleDependencies": false,
  > 37 |   "dependencies": {
  >    |   ^^^^^^^^^^^^^^
    38 |     "@hyperjump/json-pointer": "^1.0.0",
    39 |     "@hyperjump/pact": "^0.2.4",

  💡 Add "just-curry-it" as a dependency.
jdesrosiers commented 1 year ago

Thanks for pointing this out. I've released v1.4.1 with the fix.