hyperjumptech / grule-rule-engine

Rule engine implementation in Golang
Other
2.21k stars 345 forks source link

Consider migrating to `github.com/antlr/antlr4/runtime/Go/antlr/v4`? #360

Open Rick-xuy opened 1 year ago

Rick-xuy commented 1 year ago

It seems that v1 module of github.com/antlr/antlr4/runtime/Go/antlr has been deprecated.
https://github.com/antlr/antlr4/blob/master/runtime/Go/antlr/go.mod

// Deprecated: Please switch to the new v4 module path: github.com/antlr/antlr4/runtime/Go/antlr/v4 - see https://github.com/antlr/antlr4/blob/master/doc/go-target.md
module github.com/antlr/antlr4/runtime/Go/antlr

The new module is github.com/antlr/antlr4/runtime/Go/antlr/v4 and it fit more properly with the idiomatic ways of Go than v1 module.
Is there any plan to migrate to github.com/antlr/antlr4/runtime/Go/antlr/v4? If so, this doc may help.

newm4n commented 1 year ago

I have not planned to move antlr v3 to v4 yet. This improvement might take time to do and Im still struggling to find time for it.

Sudo-Shoe commented 1 year ago

Sorry to bring this back up, but as of May 30th it seems that all pre-v4 code has been moved.

https://github.com/antlr/antlr4/blob/master/doc/go-target.md#removal-of-non-v4-code

Can you consider revisiting this issue?