search

hyperjumptech / monika

Monika is a command line application to monitor every part of your web app using a simple YAML configuration file. Get alert not only when your site is down but also when it's slow.
https://monika.hyperjump.tech
MIT License
605 stars 67 forks source link

Fix: Make TLS Probe Independent #1280

Closed haricnugraha closed 7 months ago

haricnugraha commented 7 months ago

Monika Pull Request (PR)

What feature/issue does this PR add

Make TLS probe independent. It resolves #1261.

How did you implement / how did you fix it

Remove validation that requires Monika configuration to have minimum a probe request.

How to test

Run Monika with the following configuration.

certificate:
  domains:
    - example.com
    - expired.badssl.com
    - domain: example.com
      options:
        path: '/foo'
  reminder: 30
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 63.89%. Comparing base (6a29470) to head (be0ad9a). Report is 7 commits behind head on main.

Files Patch % Lines
src/jobs/tls-check.ts 27.27% 7 Missing and 1 partial :warning:
src/components/config/sanitize.ts 50.00% 2 Missing and 1 partial :warning:
...rc/components/config/validation/validator/probe.ts 86.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1280 +/- ## ========================================== + Coverage 62.51% 63.89% +1.37% ========================================== Files 112 108 -4 Lines 3391 3368 -23 Branches 591 571 -20 ========================================== + Hits 2120 2152 +32 + Misses 1079 1034 -45 + Partials 192 182 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.