search

hyperjumptech / monika

Monika is a command line application to monitor every part of your web app using a simple YAML configuration file. Get alert not only when your site is down but also when it's slow.
https://monika.hyperjump.tech
MIT License
605 stars 67 forks source link

feat(ping): #1260 deprecate ping request #1288

Closed syamsudotdev closed 6 months ago

syamsudotdev commented 6 months ago

Monika Pull Request (PR)

What feature/issue does this PR add

This PR is a deprecation step before removing ping from HTTP probe. See #1260

How did you implement / how did you fix it

  1. Remove "ping: true" from monika-config-schema.json
  2. Add deprecation warning to startup message
  3. Add deprecation warning to HTTP probe message
  4. Update ping tutorial
  5. Update monika.yml sample

How to test

  1. Setup monika configuration below
probes:
  - id: 'ping_test'
    name: ping_test
    description: requesting icmp ping
    interval: 10
    requests:
      - url: http://google.com
        ping: true
    alerts:
      - assertion: response.status != 200
        message: response status message
  1. npm run start -- -r 1
  2. Expected screenshot below image
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.77%. Comparing base (6a29470) to head (c489e90). Report is 12 commits behind head on main.

Files Patch % Lines
src/components/logger/startup-message.ts 0.00% 3 Missing and 1 partial :warning:
src/components/probe/prober/http/request.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1288 +/- ## ========================================== + Coverage 62.51% 63.77% +1.25% ========================================== Files 112 108 -4 Lines 3391 3376 -15 Branches 591 572 -19 ========================================== + Hits 2120 2153 +33 + Misses 1079 1040 -39 + Partials 192 183 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.