search

hyperlab / TiMixpanel

Mixpanel integration for Titanium Mobile
22 stars 12 forks source link

Add support for surveys and in-app notifications #22

Closed inakiabt closed 9 years ago

inakiabt commented 9 years ago

Add script to compile storyboards located on “ios/platform/iphone” Update storyboards from Mixpanel SDK 2.6.0

Tested only on iOS 8 (SDK 3.4.1 and 3.4.0).

Fixes https://github.com/hyperlab/TiMixpanel/issues/4

jonatansberg commented 9 years ago

Everything looks good! The only thing I'm wondering is if it would be possible to add the storyboard compilation as a build step in the Xcode project? Let me know if you would like to take a look at that @inakiabt, otherwise I will just pull this as is as soon as I've tested it a bit more thoroughly.

Thanks again for the great work! :)

jonatansberg commented 9 years ago

@inakiabt and @timanrebel Would you mind taking a look at my changes in 995e2e9, in order to verify that things still work as expected? I don't have a suitable environment set up to test this at the moment.

If everything looks good then we can finally go ahead and get this merged! :)

inakiabt commented 9 years ago

@mrlundis I've just tested it and it works! But there is an issue with the SDK assets: If they are located, before build the module, in assets folder, the app won't find them (no crash, but no images). If they are located in platform/iphone folder, they will be shown in the app. But, after build the module, the assets will be copied to assets too.

timixpanel-issue

I think it's not bad, but do you know how to avoid this duplication?

inakiabt commented 9 years ago

Any update on this?

jonatansberg commented 9 years ago

@inakiabt It seems weird that the assets should end up in both of those places..

I've found that you more or less have to delete the entire build folder between builds in order to get a clean build. Doing so might help with the duplication issue. Otherwise I guess this is something we will have to live with for a while, until someone finds a way to clean up the dupes.

inakiabt commented 9 years ago

@mrlundis you're right! I tested it on a clean build and it's not duplicating the assets. I updated the PR moving the images from assets to platform/iphone.

jonatansberg commented 9 years ago

Boom! Thank you so much for helping out with this @inakiabt. :D

brianjd commented 9 years ago

Great work guys!