hyperlab / TiMixpanel

Mixpanel integration for Titanium Mobile
22 stars 12 forks source link

Notification and Survey Storyboard resource fix #31

Closed miex0r closed 1 year ago

miex0r commented 8 years ago

This is not exactly merge-able, as it sits now.. but it is very close to being a proper fix to the Titanium module resource issue you guys have. Currently, as you know, in the iOS app the storyboard file for Survey's and Notifications throws an error on launch. This is because the storyboard files are not properly bundled in the .app by ti build. To fix this, a bundle should be created which houses the storyboard files and is placed in the assets folder on build... according to the Ti module documentation. I did this in this branch, however the bundle file is STILL not being copied into the .app properly.

What i ended up doing, in Mixpanel.m, was loading the bundle that we know the storyboard files are in, and using that bundle instead of the main bundle.

I unfortunately had to manually copy my storyboard.bundle to my iphone resource folder (as explained in the code comment)

Perhaps one of you guys can finish this up properly and get it into the next version?

Let me know if you have any questions.

Thanks Mike

References:

https://github.com/hyperlab/TiMixpanel/issues/29