hyperlane-xyz / hyperlane-explorer

Web app for the Hyperlane Explorer
https://explorer.hyperlane.xyz
Other
50 stars 46 forks source link

Feature/refactor try decode ica body function #69

Closed NguyenTuanCanh closed 2 months ago

NguyenTuanCanh commented 2 months ago

Here are some suggestions for improvement:

  1. Input Validation: Ensure that the input body is valid before attempting to decode it. It seems like you're checking if it's falsy or if it represents zero in a BigNumber context. However, it might be more robust to explicitly check if it's a string.
  2. Error Handling: Your code is already catching errors during decoding, which is good practice. However, it's important to handle errors appropriately and provide meaningful error messages.
  3. Type Safety: TypeScript provides powerful type checking capabilities. Ensure that you're leveraging them fully to catch potential errors at compile time.
vercel[bot] commented 2 months ago

@NguyenTuanCanh is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

jmrossy commented 2 months ago

Thanks @NguyenTuanCanh for the effort here but I don't see any real value in this change. Given that your change also fails to build and fails the formatter check, I don't think we should spend any more time on this. Sorry!