hyperlane-xyz / hyperlane-monorepo

The home for Hyperlane core contracts, sdk packages, and other infrastructure
https://hyperlane.xyz
Other
246 stars 282 forks source link

Fix QuorumProvider issues with eth_estimateGas results #1160

Closed tkporter closed 1 year ago

tkporter commented 1 year ago

Noticing QuorumProvider is having some issues with eth_estimateGas on Moonbeam - the reason is providers are returning slightly different gas estimates. This is probably because providers have slightly different node configurations or the binary search to find the gas estimate isn't deterministic. Eventually a quorum is reached, but sometimes it takes ages.

Proposed solution: similar to what we do with eth_getBlockNumber where we take the min of all responses, we take the max of all responses.

tkporter commented 1 year ago

Done with https://github.com/hyperlane-xyz/ethers-rs/pull/5, https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/1201, and https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/1237