Use overarching Error enum in agents

hyperlane-xyz / hyperlane-monorepo

The home for Hyperlane core contracts, sdk packages, and other infrastructure

https://hyperlane.xyz

Other

311 stars 341 forks source link

Use overarching Error enum in agents #2878

Open daniel-savu opened 11 months ago

daniel-savu commented 11 months ago

I'd like to have one error enum that includes ChainCommunicationError, HyperlaneCustomErrorWrapper, eyre errors, and so on. Wondering what the reasoning behind not doing this before was? cc @tkporter

Some work on this has already started in https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2881

Useful subtasks:

[ ] write a small macro to implement From<Err> for ChainCommunicationError for all the sub-errors of HyperlaneCosmosError et al

nambrot commented 7 months ago

@daniel-savu still relevant I assume?

daniel-savu commented 7 months ago

It is yes. We've already started consolidating environment-specific errors into ChainCommunicationError using the From trait impl approach (example here for cosmos), but it's a work in progress and many errors are still standalone.