hyperlane-xyz / hyperlane-monorepo

The home for Hyperlane core contracts, sdk packages, and other infrastructure
https://hyperlane.xyz
Other
336 stars 369 forks source link

Warp route deployment should be able to handle multiple collaterals #3666

Closed ltyu closed 5 months ago

ltyu commented 6 months ago

Problem

Currently, the CLI cannot handle a config with multiple collaterals on different chains. For example,

arbitrum:
  type: native
  address: "0x0000000000000000000000000000000000000000"
  isNft: false
polygon:
  type: native
  address: "0x0000000000000000000000000000000000000000"
  isNft: false
zksync:
  type: synthetic

This is due to runBuildConfigStep() of warp.ts overwriting baseChainName and baseMetadata for multiple collaterals. These variables are then passed downstream to be used in deploy plan and dryrun.

Also, buildTokenMetadata() of HypERC20/HypERC721Deployer is duplicated in the CLI.

Solution

Nice to Have

yorhodes commented 5 months ago

fixed by https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/3820