Closed nambrot closed 3 months ago
What kind of breakage are you anticipating?
I'm fine with continuing to supporting copied over warp configs in the warp UI, but in chatting with @yorhodes it is a much nicer DX to just point to a (fork of a) registry which contains both the chain and warp config
It kinda feels even worse to use the registry to fetch the chain metadata, but then not allow the usage of a config which is in the registry, and it has to be copied over
It kinda feels even worse to use the registry to fetch the chain metadata, but then not allow the usage of a config which is in the registry, and it has to be copied over
@nambrot I hear you on this. We'd need some more tooling that we haven't built yet. A 'give me warp route for token X on chains A, B, C' because Nexus is a mix of a bunch of different routes. Some of which, like the IBC ones, are not in the registry.
I'm also concerned about the security implications given that the registry may have many contributors.
Overall, I'm open to it but I want to discuss it first please
@nambrot I hear you on this. We'd need some more tooling that we haven't built yet. A 'give me warp route for token X on chains A, B, C' because Nexus is a mix of a bunch of different routes. Some of which, like the IBC ones, are not in the registry.
can we have a non Nexus build that works against an arbitrary registry? this is especially useful for folks just forking
can we have a non Nexus build that works against an arbitrary registry? this is especially useful for folks just forking
@yorhodes We could have main
do that if we want, but leave the 3 production branches static.
@jmrossy I definitely hear you that there are some implications of a) approving a PR into the registry in the first place + b) listing on a Abacus Works hosted instance of the Warp UI.
Like @yorhodes mentioned, IMO, we should allow for a template UI to be configured with an arbitrary registry URI (to support a user's registry fork at minimum), but to account for your concern, we could allow for allowlisting a specific subset or have a commitment to a list of warp routes to have deployments explicitly acknowledge a set of changed warp routes?
Like @yorhodes mentioned, IMO, we should allow for a template UI to be configured with an arbitrary registry URI (to support a user's registry fork at minimum), but to account for your concern, we could allow for allowlisting a specific subset or have a commitment to a list of warp routes to have deployments explicitly acknowledge a set of changed warp routes?
yes, I think nexus or whatever AW instance should have stronger review requirements on token inclusion
cc @cmcewen related to broader warp UI scope decision
I configured a 1 click vercel deploy link here
support via HYP_REGISTRY_URL
the set of chains and warp routes to pull
@jmrossy - @yorhodes mentioned that we might need an additional allowlist for things to selectively allow which routes show up in nexus
@nambrot I'm not totally convinced on pulling the warp configs from the registry. Chains yes but it feels fragile to have the warp instances be potentially broken by changes in a separate repo.