hyperlane-xyz / hyperlane-monorepo

The home for Hyperlane core contracts, sdk packages, and other infrastructure
https://hyperlane.xyz
Other
239 stars 271 forks source link

Ensure ISM Configs are all objects (no more `Address`) #3773

Open paulbalaji opened 1 month ago

paulbalaji commented 1 month ago

Currently the IsmConfig type states that configs can be an Address - which is just a string. We should remove this and ensure all ISM configs are objects containing type at the very least https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/03ca2d1df76a7654450b71bf5bf80c40842b58e0/typescript/sdk/src/ism/types.ts#L104

MVP idea:

Should also tidy up all the if (typeof config === 'string') cases we have scattered around as part of this

yorhodes commented 1 month ago

chatted offline with @paulbalaji and we will also make this change for HookConfig