Open paulbalaji opened 1 month ago
Currently the IsmConfig type states that configs can be an Address - which is just a string. We should remove this and ensure all ISM configs are objects containing type at the very least https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/03ca2d1df76a7654450b71bf5bf80c40842b58e0/typescript/sdk/src/ism/types.ts#L104
IsmConfig
Address
string
type
MVP idea:
address
export type IsmAddressConfig = { type: IsmType.Address; address: Address; }
Should also tidy up all the if (typeof config === 'string') cases we have scattered around as part of this
if (typeof config === 'string')
chatted offline with @paulbalaji and we will also make this change for HookConfig
HookConfig
Currently the
IsmConfig
type states that configs can be anAddress
- which is just astring
. We should remove this and ensure all ISM configs are objects containingtype
at the very least https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/03ca2d1df76a7654450b71bf5bf80c40842b58e0/typescript/sdk/src/ism/types.ts#L104MVP idea:
type
andaddress
Should also tidy up all the
if (typeof config === 'string')
cases we have scattered around as part of this