search

hyperlane-xyz / hyperlane-monorepo

The home for Hyperlane core contracts, sdk packages, and other infrastructure
https://hyperlane.xyz
Other
338 stars 373 forks source link

chore: Remove ismFactoryAddresses from warpConfig #4888

Closed ltyu closed 4 days ago

ltyu commented 4 days ago

Description

Remove ismFactoryAddresses, which was added to the WarpConfig to be used in WarpModule, and passed into IsmModule.

This is tech debt that was added before passing in addresses via the constructor as done here: https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/111e24153250cf702ba8d31970daa855cf7954ec/typescript/sdk/src/ism/EvmIsmModule.ts#L65

Backward compatibility

Yes

Testing

Unit Tests

changeset-bot[bot] commented 4 days ago

🦋 Changeset detected

Latest commit: d132521953d33f1172f284602fa02b5b869055e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | --------------------------- | ----- | | @hyperlane-xyz/cli | Minor | | @hyperlane-xyz/sdk | Minor | | @hyperlane-xyz/helloworld | Minor | | @hyperlane-xyz/infra | Minor | | @hyperlane-xyz/widgets | Minor | | @hyperlane-xyz/ccip-server | Minor | | @hyperlane-xyz/github-proxy | Minor | | @hyperlane-xyz/utils | Minor | | @hyperlane-xyz/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.60%. Comparing base (79e9d02) to head (d132521). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4888 +/- ## ======================================= Coverage 74.60% 74.60% ======================================= Files 103 103 Lines 1516 1516 Branches 195 195 ======================================= Hits 1131 1131 Misses 364 364 Partials 21 21 ``` | [Components](https://app.codecov.io/gh/hyperlane-xyz/hyperlane-monorepo/pull/4888/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperlane-xyz) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/hyperlane-xyz/hyperlane-monorepo/pull/4888/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperlane-xyz) | `84.61% <ø> (ø)` | | | [hooks](https://app.codecov.io/gh/hyperlane-xyz/hyperlane-monorepo/pull/4888/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperlane-xyz) | `77.77% <ø> (ø)` | | | [isms](https://app.codecov.io/gh/hyperlane-xyz/hyperlane-monorepo/pull/4888/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperlane-xyz) | `79.02% <ø> (ø)` | | | [token](https://app.codecov.io/gh/hyperlane-xyz/hyperlane-monorepo/pull/4888/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperlane-xyz) | `89.07% <ø> (ø)` | | | [middlewares](https://app.codecov.io/gh/hyperlane-xyz/hyperlane-monorepo/pull/4888/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperlane-xyz) | `77.58% <ø> (ø)` | |

🚨 Try these New Features: