hyperledger-archives / aries-framework-dotnet

Aries Framework .NET for building multiplatform SSI services
https://wiki.hyperledger.org/display/aries
Apache License 2.0
84 stars 74 forks source link

Set id and type for CreateInboxResponseMessage #126

Closed adrijanrogan closed 4 years ago

adrijanrogan commented 4 years ago

Short description of what this resolves:

CreateInboxResponseMessage does not have @id and @type agent message properties set. This can cause issues for a generic agent message handler that uses @type for delegating message handling to a specific handler.

Changes proposed in this pull request:

Fixes: #

Would it also make sense to add a thread decorator referring back to the initial CreateInboxMessage? That would be more in line with Aries RFCs, but creating an inbox is generally using duplex communication, so it seems redundant.