search

hyperledger-archives / aries-framework-dotnet

Aries Framework .NET for building multiplatform SSI services
https://wiki.hyperledger.org/display/aries
Apache License 2.0
84 stars 74 forks source link

Using GetAsync method instead of ListAsync method for getting credent… #133

Closed RinkalBhojani closed 4 years ago

RinkalBhojani commented 4 years ago

@tmarkovski @StevenTCramer

Short description of what this resolves:

Enhancement in code- Update in class GetCredentialHandler

Changes proposed in this pull request:

Use GetAsync() method instead of ListAsync() method

Fixes: https://github.com/hyperledger/aries-framework-dotnet/issues/132

tmarkovski commented 4 years ago

Thanks for your contribution @RinkalBhojani Per Hyperledger's guidelines, all commits must be signed, so that the DCO requirement will pass. Please see this link on how to quickly amend your commit with signed message.

https://github.com/hyperledger/aries-framework-dotnet/pull/133/checks?check_run_id=1181975638

RinkalBhojani commented 4 years ago

Thanks for your contribution @RinkalBhojani Per Hyperledger's guidelines, all commits must be signed, so that the DCO requirement will pass. Please see this link on how to quickly amend your commit with signed message.

https://github.com/hyperledger/aries-framework-dotnet/pull/133/checks?check_run_id=1181975638

Signed-off the commit. Do I need to create new pull request or you can approve the same? Thanks