Make few functions extendable with virtual keywords

hyperledger-archives / aries-framework-dotnet

Aries Framework .NET for building multiplatform SSI services

https://wiki.hyperledger.org/display/aries

Apache License 2.0

84 stars 74 forks source link

Make few functions extendable with virtual keywords #135

Closed naagii closed 4 years ago

naagii commented 4 years ago

Short description of what this resolves:

To make public functions of default proof service extendable.

Changes proposed in this pull request:

To add the virtual keyword to a few function declarations.
To move public functions out of the so-called private methods region.

Fixes: #

tmarkovski commented 4 years ago

Thanks for the PR. Please add sign-off commits, per DCO requirements - https://github.com/hyperledger/aries-framework-dotnet/pull/135/checks?check_run_id=1216364491

naagii commented 4 years ago

Because of not being familiar with the commands to amend the signature of the previous commit, I managed to ruin the PR. I will close this one and submit a new PR with a signed-off commit.