Add pagination support for SearchAsync

hyperledger-archives / aries-framework-dotnet

Aries Framework .NET for building multiplatform SSI services

https://wiki.hyperledger.org/display/aries

Apache License 2.0

84 stars 74 forks source link

Add pagination support for SearchAsync #146

Closed victorbalan closed 3 years ago

victorbalan commented 3 years ago

Short description of what this resolves:

Add simple pagination in the DefaultWalletRecordService

Changes proposed in this pull request:

add skip parameter to the SearchAsync method

tmarkovski commented 3 years ago

Thanks for this PR @victorbalan , sorry for the delayed review, we had issues with Travis CI. We had to remove this integration step for the time being. Could you please run the test suite locally on your branch and confirm that all tests are passing, so we can merge this PR?

You can run it using docker-compose -f docker-compose.test.yaml up --build --abort-on-container-exit --exit-code-from test-agent

victorbalan commented 3 years ago

Yep. @tmarkovski it looks like all of them are passing.