search

hyperledger-archives / aries-framework-dotnet

Aries Framework .NET for building multiplatform SSI services
https://wiki.hyperledger.org/display/aries
Apache License 2.0
84 stars 74 forks source link

Mediator Metadata #161

Open Alexis-Falquier opened 3 years ago

Alexis-Falquier commented 3 years ago

It seems like the mediator was intended to be able to hold metadata about a registered inbox as there is an optional parameter "metadata" on the function "CreateInboxAsync" (code here) but where this function is called on the edge functionality it does not give the option to pass in metadata (code here) On the mediator side of things we looked at the function that handles this (code here) and found that even if the metadata was passed it does nothing with it.

did we by chance miss something and there is still a way to set and get metadata for an inbox in the mediator? Or was this functionality abandoned?

tmarkovski commented 3 years ago

Yeah, this sounds like it was intended, but never actually used. Sounds like we just need to make small changes to make this work.

Alexis-Falquier commented 3 years ago

So we are going to need this functionality and will be happy to make these changes and make a PR do you happen to know what specifically needs to be changed? Seems like the scope of these changes should be fairly minimal correct?

MaticDiba commented 3 years ago

Hi @tmarkovski, we prepared a fix for this with unit tests. Please review this #164

Any comments more then welcome.

tmarkovski commented 3 years ago

Thank, merged. If you need this released, can you submit a PR with the version bumped at https://github.com/hyperledger/aries-framework-dotnet/blob/e475b20cfba5b0be11e614e66d8633d5bd21ca98/Directory.Build.props#L12, so we can publish it to nuget?

MaticDiba commented 3 years ago

Thank you. We will prepare another one. Will add version bump to that one.