MongoDB tests don't work - Githubissues

hyperledger-archives / aries-framework-go-ext

https://wiki.hyperledger.org/display/aries

Apache License 2.0

14 stars 22 forks source link

MongoDB tests don't work #22

Closed soluchok closed 4 years ago

soluchok commented 4 years ago

make unit-test command runs all unit tests. Currently, MongoDB tests are not working properly. MongoDB depends on the docker image. But Image isn’t created anywhere. Theoretically, tests should fail but they are not. The problem is with os.Exit(0). Even if an error happens we exit with a successful code (0). See https://github.com/hyperledger/aries-framework-go-ext/blob/main/component/storage/mongodb/mongodb_test.go#L47

What needs to be done?

when an error happens the exit code must be greater than 0
docker image needs to be set up (e.g dockertest is preferable)

soluchok commented 4 years ago

@pfeairheller ^