hyperledger-archives / aries-framework-go-ext

https://wiki.hyperledger.org/display/aries
Apache License 2.0
14 stars 22 forks source link

chore: Don't add empty anchor origin to sidetree requests #295

Closed sandrask closed 1 year ago

sandrask commented 1 year ago

Currently sidetree client adds anchorOrigin even when it is empty. Only add anchor origin to create/recover requests if anchor origin is not empty.

Closes #294

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #295 (58a9645) into main (0c41ff0) will decrease coverage by 3.00%. The diff coverage is 42.85%.

:exclamation: Current head 58a9645 differs from pull request most recent head dd1da0c. Consider uploading reports for the commit dd1da0c to get more accurate results

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   85.27%   82.26%   -3.01%     
==========================================
  Files          25        2      -23     
  Lines        4000      344    -3656     
==========================================
- Hits         3411      283    -3128     
+ Misses        352       31     -321     
+ Partials      237       30     -207     
Impacted Files Coverage Δ
component/vdr/sidetree/client.go 81.62% <42.85%> (-1.05%) :arrow_down:
component/vdr/trustbloc/models/consortium.go
...vdr/trustbloc/discovery/staticdiscovery/service.go
...b/util/concurrent/rollingcounter/rollingcounter.go
...nt/vdr/trustbloc/config/verifyingconfig/service.go
component/storage/postgresql/store.go
component/storage/couchdb/store.go
...nt/vdr/trustbloc/config/signatureconfig/helpers.go
component/vdr/orb/internal/ldcontext/ldcontext.go
...vdr/trustbloc/selection/staticselection/service.go
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.