hyperledger-archives / aries-framework-go-ext

https://wiki.hyperledger.org/display/aries
Apache License 2.0
14 stars 22 forks source link

chore: Add options to VDR accept; update long-form logic #306

Closed sandrask closed 1 year ago

sandrask commented 1 year ago

Currently VDR makes decision on whether to accept or reject request based on method only. Add options to VDR Accept function so VDR can make more complex decisions (for example long-form VDR should reject request if number of parts in DID is not at least four)

Closes #305

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #306 (0cd16ca) into main (12fe918) will decrease coverage by 6.27%. The diff coverage is 100.00%.

:exclamation: Current head 0cd16ca differs from pull request most recent head 9d06a57. Consider uploading reports for the commit 9d06a57 to get more accurate results

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   85.21%   78.94%   -6.28%     
==========================================
  Files          34       16      -18     
  Lines        4112     1439    -2673     
==========================================
- Hits         3504     1136    -2368     
+ Misses        364      189     -175     
+ Partials      244      114     -130     
Impacted Files Coverage Δ
component/vdr/longform/vdr.go 85.71% <100.00%> (+1.50%) :arrow_up:
component/vdr/orb/vdr.go 70.47% <100.00%> (ø)
...mponent/vdr/trustbloc/config/httpconfig/service.go
component/vdr/trustbloc/vdr.go
component/vdr/trustbloc/endpoint/service.go
component/storage/mysql/store.go
...trustbloc/config/updatevalidationconfig/service.go
...nent/vdr/trustbloc/models/sidetreeconfiguration.go
component/vdr/trustbloc/models/stakeholder.go
...omponent/vdr/trustbloc/didconfiguration/helpers.go
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.