search

hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
238 stars 159 forks source link

service.Header.Purpose? #1040

Open llorllale opened 4 years ago

llorllale commented 4 years ago

https://github.com/hyperledger/aries-framework-go/blob/4d6d2333de088df2e2f555065ad99f4090a0be5d/pkg/didcomm/common/service/service.go#L42-L49

My mental model of service.Header.Purpose was that of a collection of common attributes that all DIDComm protocols share: @id, @type, ~thread, etc. Which is why the addition of ~purpose does not make sense as it is defined by a very specific protocol.

Should the handling of ~purpose be contained within its specific protocol service package?

sudeshrshetty commented 4 years ago

We have a plan to move all the decorators out to separate struct, I am not sure if we already have a in-progress issue for this.