search

hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

"CredentialStatusList2017" treated as invalid/unknown element in JSON-LD normalization. #1697

Open sudeshrshetty opened 4 years ago

sudeshrshetty commented 4 years ago

Once we upgrade to new spec, custom option passed through proof verifier to exclude "CredentialStatusList2017" in invalid dataset list to be removed.

troyronda commented 4 years ago

CredentialStatusList2017 should be treated as an example. Need to include an example context that defines it.

kdimak commented 4 years ago

@troyronda added https://trustbloc.github.io/context/vc/examples-v1.jsonld

troyronda commented 4 years ago

@kdimak yup .... I was curious if we can cache a context locally in the repo in case the above link goes down or disappears. (to make tests less fragile).

kdimak commented 4 years ago

yes, this makes sense @troyronda I created https://github.com/hyperledger/aries-framework-go/issues/1753. I think we can close this issue as to close https://github.com/hyperledger/aries-framework-go/pull/1735 we added WithExternalJSONLDContext() WithJSONLDOnlyValidRDF() options.

troyronda commented 4 years ago

@sudeshrshetty can this be closed?