search

hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
238 stars 159 forks source link

basicmessage service: wrong package path #2270

Open llorllale opened 3 years ago

llorllale commented 3 years ago

The basicmessage service is in the wrong package path and should be moved under pkg/didcomm/protocol.

Also, we should revisit these open issues:

troyronda commented 3 years ago

Also we should remove the last remnant of the old message type URI (did:sov:BzCbsNYhMrjHiqZDTUASHg;spec). https://github.com/hyperledger/aries-framework-go/blob/9c1b42e24dc9498100e84cf067bd36ab7ee5c2ba/pkg/didcomm/messaging/service/basic/basicmsgsvc_test.go#L73