search

hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
238 stars 159 forks source link

Don't import edv package directly in wallet package #2815

Open DRK3 opened 3 years ago

DRK3 commented 3 years ago

Currently the wallet package imports the edv storage provider, which is in another module. This creates an undesirable dependency on the edv module from the main aries go module. We should rework the wallet package to not be hard-coded to edv, and instead allow the encrypted storage solution to be injected in. This may require creating a new interface in spi.

Once this is done, we don't need the github.com/hyperledger/aries-framework-go/component/storage/edv => ../../component/storage/edv replaces in the command modules.

sudeshrshetty commented 3 years ago

wallet should have a internal default EDV implementation where wallet user can just pass an EDV URL & keys and expect wallet to use that EDV for storing contents.

DRK3 commented 1 year ago

Another solution: move the wallet package to a new module