hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

DID Comm V2 - Incorrect controller data models #3106

Open sudeshrshetty opened 2 years ago

sudeshrshetty commented 2 years ago

Due to recent updates in normalizing command controllers for DIDComm V1 & V2 support, command controller data models are not actually matching with the actual parameters a command controller is expecting.

sudeshrshetty commented 2 years ago

For example: even though a command controller function says it accepts GenericInvitation it actually accepts outofband.Invitation V1 or outofband.Invitation V2. Hard for clients to find out what to send as request.

sudeshrshetty commented 2 years ago

also, wallet users has to convert aries out of band invitation manually to generic invitation in order to use wallet. Need better design.