search

hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

Consider tagging submodule "spi"? #3530

Open Rick-xuy opened 1 year ago

Rick-xuy commented 1 year ago

I found that package github.com/hyperledger/aries-framework-go/spi/storage is placed in submodule github.com/hyperledger/aries-framework-go/spi instead of root module.
However, it seems that submodule github.com/hyperledger/aries-framework-go/spi is not tagged. According to Go Modules wiki, submodule should be tagged like relative-path-to-root/vX.X.X. At now, when trying to import package github.com/hyperledger/aries-framework-go/spi/storage, downstream would depends on pseudo-version of module github.com/hyperledger/aries-framework-go/spi.

github.com/hyperledger/aries-framework-go/spi v0.0.0-20211206182816-9cdcbcd09dc2

I think it is not very readable and difficult to upgrade. This is not conductive to version control either. So, I propose whether it is possible to tag submodule properly. For example, spi/v0.0.1, spi/v0.1.8etc, so that other project can use tag to import this module in go.mod.