hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

fix: Match submission requirements not apply limited disclosure. #3559

Closed vkubiv closed 1 year ago

vkubiv commented 1 year ago

Title:

MatchSubmissionRequirement no longer applies limited disclosure on its results, now it just filters applicable credentials.

Summary:

Functionality that applies limited disclosure was factored from filterConstraints to separate function limitDisclosure.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3559 (ed2d845) into main (344a7f8) will decrease coverage by 0.01%. The diff coverage is 95.08%.

@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
- Coverage   87.76%   87.75%   -0.01%     
==========================================
  Files         351      351              
  Lines       48612    48646      +34     
==========================================
+ Hits        42662    42689      +27     
- Misses       4402     4407       +5     
- Partials     1548     1550       +2     
Impacted Files Coverage Δ
pkg/doc/presexch/definition.go 85.32% <95.08%> (-0.11%) :arrow_down:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.