hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

perf: remove extra parsing #3566

Closed skynet2 closed 1 year ago

skynet2 commented 1 year ago

verifySignature does not require parsed claims to do that functionality. we already parsing claims in many other places. image

codecov[bot] commented 1 year ago

Codecov Report

Merging #3566 (6d51a58) into main (dbfff0c) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 6d51a58 differs from pull request most recent head 33fe70b. Consider uploading reports for the commit 33fe70b to get more accurate results

@@            Coverage Diff             @@
##             main    #3566      +/-   ##
==========================================
- Coverage   87.76%   87.76%   -0.01%     
==========================================
  Files         351      351              
  Lines       48636    48627       -9     
==========================================
- Hits        42685    42677       -8     
+ Misses       4403     4402       -1     
  Partials     1548     1548              
Impacted Files Coverage Δ
pkg/doc/jwt/verifier.go 76.78% <100.00%> (-1.19%) :arrow_down:
pkg/doc/signature/verifier/verifier.go 95.00% <100.00%> (ø)
pkg/doc/verifiable/embedded_proof.go 82.52% <100.00%> (-0.50%) :arrow_down:
pkg/doc/verifiable/linked_data_proof.go 85.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.