hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

feat: Improvements to ECDSA2019 DI API #3618

Closed DRK3 closed 1 year ago

DRK3 commented 1 year ago

The existing API required an interface that defines many more methods than what are actually required, which forces consumers of the API to implement many methods that won't ever be called. The API has now been changed to make use of two minimal interfaces instead, making it easier to use and understand. Note that implementations of the larger crypto interface can still be used since the minimal interface method signatures match.

To avoid potential confusion with the new interface names, two existing constructors were renamed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3618 (a1a50c4) into main (71e132b) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
- Coverage   86.94%   86.94%   -0.01%     
==========================================
  Files         367      367              
  Lines       50011    50020       +9     
==========================================
+ Hits        43484    43490       +6     
- Misses       4943     4945       +2     
- Partials     1584     1585       +1     
Files Changed Coverage Δ
.../models/dataintegrity/suite/ecdsa2019/ecdsa2019.go 93.67% <100.00%> (+0.34%) :arrow_up:

... and 1 file with indirect coverage changes