hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

feat: change KMS interface for Data Integrity #3621

Closed mishasizov-SK closed 1 year ago

mishasizov-SK commented 1 year ago

Title: Change KMS interface for Data Integrity.

Summary:

  1. Introduced private KMS interface for ecdsa2019 Data integrity suite with only onte method.
  2. Made publicKeyBytesToHandle function as exported from localkms package and used it in ecdsa2019 Data integrity suite verifier. The reason for it is that method
    func (l *LocalKMS) PubKeyBytesToHandle(pubKey []byte, kt kmsapi.KeyType, opts ...kmsapi.KeyOpts) (interface{}, error) {
    return publicKeyBytesToHandle(pubKey, kt, opts...)
    }

    does not use receiver and func PublicKeyBytesToHandle can be used independently.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3621 (934c9d7) into main (cce322d) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3621      +/-   ##
==========================================
- Coverage   86.94%   86.93%   -0.01%     
==========================================
  Files         367      367              
  Lines       50020    50020              
==========================================
- Hits        43490    43487       -3     
- Misses       4945     4947       +2     
- Partials     1585     1586       +1     
Files Changed Coverage Δ
component/kmscrypto/kms/localkms/localkms.go 81.42% <100.00%> (ø)
component/kmscrypto/kms/localkms/pubkey_reader.go 75.57% <100.00%> (ø)
.../models/dataintegrity/suite/ecdsa2019/ecdsa2019.go 91.95% <100.00%> (-1.73%) :arrow_down: