Closed mishasizov-SK closed 1 year ago
Merging #3630 (82c6456) into main (717faac) will decrease coverage by
0.01%
. The diff coverage is82.19%
.
@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
- Coverage 86.93% 86.92% -0.01%
==========================================
Files 367 367
Lines 50046 50098 +52
==========================================
+ Hits 43507 43549 +42
- Misses 4954 4961 +7
- Partials 1585 1588 +3
Files Changed | Coverage Δ | |
---|---|---|
component/models/dataintegrity/signer.go | 83.57% <81.15%> (+0.23%) |
:arrow_up: |
.../models/dataintegrity/suite/ecdsa2019/ecdsa2019.go | 93.18% <100.00%> (-0.37%) |
:arrow_down: |
Using ResolveSigningVMWithRelationship function causes a bug in VM relationship verification for Data integrity.
VerificationRelationshipGeneral
andAuthentication
. Values for those keys are verification methods with the sameID
field.for ... range
loop is not predictable. It might be a case, when first element will beVerificationRelationshipGeneral
.""
takes place and declares hardcoded relationship.