search

hyperledger-archives / aries-protocol-test-suite

Test Suite for testing protocol compliance of Aries Agents
https://wiki.hyperledger.org/display/aries
Apache License 2.0
25 stars 19 forks source link

Adding support for the issue-credential protocol family #25

Closed smithbk closed 4 years ago

smithbk commented 4 years ago

Signed-off-by: Keith Smith bksmith@us.ibm.com

dbluhm commented 4 years ago

Awesome work, thank you for your contribution. I have a few suggestions regarding the overall structure:

From a top level, this PR introduces two things: tests for issue credential with the Indy provider and a docker setup to run an Indy ledger and run tests with that setup. While the inclusion of the docker setup is definitely helpful, especially in encouraging agent developers to actually take the step to integrate this into their CI/CD pipelines, I think that this repository at least should remain focused on producing a locally installable program that can in turn be easily run within docker, VMs, etc. However, I am in favor of including example CI/CD docker files or linking to sister repositories that containerize the full setup; I think that approach keeps us inline with the test suite RFC while still providing a starting point for developers intending to integrate the test suite into their pipelines. I also think this will help those outside the Indy community to use the test suite without bringing in Indy dependencies.

If possible, it would be helpful for this PR to be split up into the addition of issue credential tests and docker changes so the two can be considered separately.