hyperledger-archives / caliper

A blockchain benchmark framework to measure performance of multiple blockchain solutions
Apache License 2.0
74 stars 24 forks source link

Docker monitor to calculate the CPU stats for the remote containers not taking no. of CPUs into account #28

Closed nitesh7sid closed 6 years ago

nitesh7sid commented 7 years ago

Hi, I am using caliper to do a benchmark test for Hyperledger fabric ledger. I noticed few things in the caliper code: 1) CPU stats calculation for remote docker containers in monitor-docker.js file https://github.com/Huawei-OSG/caliper/blob/master/src/comm/monitor-docker.js#L84 does not take CPU's count as a multiplying factor. Is there any specific reason for it ? The result obtained is actually half of the one obtained with docker stats container_id command computed locally.

haojun commented 6 years ago

Hi, thanks for pointing out the bug. Already fixed.