hyperledger-archives / education

Hyperledger training material
https://wiki.hyperledger.org/display/LMDWG
Apache License 2.0
372 stars 360 forks source link

Edx issue103 #105

Open nathalie-ckc opened 6 years ago

nathalie-ckc commented 6 years ago

Building on top of @atc-vince 's PR#104.

Each item from Github issue #103 is implemented as a separate commit. In case any of those items are not desired to be implemented, just the desired items can be cherry picked.

atc-vince commented 6 years ago

Since we currently have multiple Pull Requests in flight, do we need to keep track of the order they are to be merged (assuming a passed review)?

If so, the order appears to be as follows:

  1. PR#102 (Chapter 8)
  2. PR#104 (Chapter 6 & 7)
  3. PR#105 (Issue #103)

On Oct 7, 2018, at 9:35 PM, Nathalie Chan King Choy notifications@github.com wrote:

Building on top of @atc-vince 's PR#104.

Each item from Github issue #103 is implemented as a separate commit. In case any of those items are not desired to be implemented, just the desired items can be cherry picked.

You can view, comment on, or merge this pull request online at:

https://github.com/hyperledger/education/pull/105

Commit Summary

Chapter 8: What's Next Markdown Chapters 6 & 7 Markdown w/ Images Issue #103 item 1: Fix typo Issue #103 item 2: Move diagram to relevant slide Issue #103 item 3: Update version in command Issue #103 item 4: Indicate what we want replaced Issue #103 item 5: Specify 'fabric' Issue #103 item 6: specify what to replace Issue #103 item 7: Delete redundant slide Issue #103 item 8: Add troubleshooting tips File Changes

M LFS171x/docs/introduction-to-hyperledger-fabric.md (1545) M LFS171x/docs/introduction-to-hyperledger-sawtooth.md (969) M LFS171x/docs/whats-next.md (65) A LFS171x/images/introduction-to-hyperledger-fabric/Demonstrated_Tuna_Fishing_Scenario.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Fabric_demonstrated_scenario_actors.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Fabric_installation_1.jpg (0) A LFS171x/images/introduction-to-hyperledger-fabric/Invoke_method_queryTuna_and_changeTuna.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Invoke_method_queryTuna_and_queryAllTuna.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Invoke_method_recordTuna.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/KeyComponents-_Transaction_Proposal.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Key_Components_Channels.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/State_Database.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/The_role_of_membership_service_provider.jpg (0) A LFS171x/images/introduction-to-hyperledger-fabric/Transaction_Flow_Step_4.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Transaction_Flow_Step_5.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Transaction_Flow_Step_6.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Transaction_flow_step_2.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/Transaction_flow_step_3.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-application-flow.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-application-flowbasics.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-application1.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-changeTunaHolder.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-changedRecord.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-createTunaRecord.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-filestructure.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-query.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-queryAfterCreate.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric-queryAll.png (0) A LFS171x/images/introduction-to-hyperledger-fabric/fabric_salescenario.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/2-SawtoothDemonstrated_Scenario_1.jpg (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Accept_Tuna.jpg (0)
A LFS171x/images/introduction-to-hyperledger-sawtooth/Application_Flow.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/File_structure_of_TunaChain_Application.jpeg (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Hyperledger_Sawtooth_Components.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Miriam_can_use_the_client_application_to_query_the_ledger.jpg (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Regulators_may_use_the_client_application_to_query_the_ledger__to_verify_legitimacy.jpg (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Sarah_uses_the_client_application_to_record_all_caught_tuna_to_the_ledger.jpg (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Sawtooth_Application.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Sawtooth_Network.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/The_processing_plant_may_use_the_client_application_to_query_the_ledger.jpg (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Tuna_Create.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Tuna_Create_New_Key_Pair.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Tuna_Holder_drop_down.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Tuna_List.png (0) A LFS171x/images/introduction-to-hyperledger-sawtooth/Tuna_Transfer.png (0) A LFS171x/images/whats-next/Hyperledger_Global_Meetups.png (0) A LFS171x/images/whats-next/Hyperledger_Working_Groups.png (0)
Patch Links:

https://github.com/hyperledger/education/pull/105.patch https://github.com/hyperledger/education/pull/105.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

nathalie-ckc commented 6 years ago

I just realized that in deleting the redundant slide for item 7, the table of contents didn't get updated. I'll fix that today.

nathalie-ckc commented 6 years ago

OK, just pushed that change for item 7. Feel free to cherry pick whichever items from issue #103 that you think are valid, and leave behind the rest.

DBAti commented 6 years ago

Hi Nathalie,

Thanks for the email, the issue I was facing is about the deprecated functions "eventhub" I have solved it for, My point in the meeting was to have it somewhere in the example or we should add to pull the docker image of 1.2.0 or match it with the node SDK, it took 5-6 hours to understand the issue which should not be the case, the only thing I want to point out is the Docker image and node SDK should pull the version.

Best Regards,

AtiSenior PHP Developer

On Mon, Oct 22, 2018 at 9:22 PM Nathalie Chan King Choy < notifications@github.com> wrote:

@nathalie-ckc commented on this pull request.

In LFS171x/docs/introduction-to-hyperledger-fabric.md https://github.com/hyperledger/education/pull/105#discussion_r227031728:

@@ -415,7 +415,7 @@ If you need further details on these prerequisites, visit Chapter 4, _Technical Next, we will download the latest released Docker images for Hyperledger Fabric, and tag them with the latest tag. Execute the command from within the directory into which you will extract the platform-specific binaries:


-$ curl -sSL https://goo.gl/6wtTN5 | bash -s 1.1.0
+$ curl -sSL https://goo.gl/6wtTN5 | bash -s 1.2.0

@DBAti <https://github.com/DBAti>, you mentioned in today's Training &
Education Working Group call that you hit issues with the 1.3 Fabric stuff?
I just went to the end of the 1st example with the 1.3.0 instruction above
that Tracy gave. I didn't have time to go through entire chapter with 1.3.
Please could you let us know the details of what you encountered?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/hyperledger/education/pull/105#discussion_r227031728>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQF6yRLgfgtEb83I9xBDu-NyXTslOsUxks5unempgaJpZM4XMJE7>
.