search

hyperledger-archives / education

Hyperledger training material
https://wiki.hyperledger.org/display/LMDWG
Apache License 2.0
372 stars 360 forks source link

Add Composer chapter #65

Closed alexvicegrab closed 6 years ago

alexvicegrab commented 6 years ago

Provisional pull request for Hyperledger Composer material for EdX course.

tkuhrt commented 6 years ago

Any chance we can get this pull request against a branch? We don't want to update the master branch until the course material has been released.

alexvicegrab commented 6 years ago

@tkuhrt, pulling against branch add-composer

tkuhrt commented 6 years ago

Thanks @alexvicegrab. Can you check out some of the work that we are doing on the import-edx-content branch (e.g., https://github.com/hyperledger/education/blob/import-edx-content/LFS171x/docs/discovering-blockchain-technologies.md)? I am wondering if we might follow this format for the new Composer chapter so that when we get all of these changes added to the master branch, they will be similar. In the meantime, I will review the material and see if I have any additional comments.

alexvicegrab commented 6 years ago

Hi Tracy, we'll work on your suggestions and make the section more in line with the current version, as you suggested (https://github.com/hyperledger/education/blob/import-edx-content/LFS171x/docs/discovering-blockchain-technologies.md)

tkuhrt commented 6 years ago

Thanks, Sasha and Nicola. I finally was able to run through setting up a VM and running through the install an example on the VM. I left a few more comments on the source code. This looks really great! People are going to get a ton out of this material!

alexvicegrab commented 6 years ago

Hi @tkuhrt, we will review your comments, thank you!

alexvicegrab commented 6 years ago

@tkuhrt, I think I implemented all of your above suggestions. Please let us know if there are any further improvements. Thank you again!

tkuhrt commented 6 years ago

Thanks for being so patient and resolving my comments. This looks good to me. I will commit it to the add-composer branch.