search

hyperledger-archives / fabric

THIS IS A READ-ONLY historic repository. Current development is at https://gerrit.hyperledger.org/r/#/admin/projects/fabric . pull requests not accepted
https://gerrit.hyperledger.org/
Apache License 2.0
1.17k stars 1.01k forks source link

asset management test case should be moved out of examples/... path #1039

Open muralisrini opened 8 years ago

muralisrini commented 8 years ago

asset management test case will not be run as part of the running unit test case per doc directions if its under examples/... folder. It should be moved to chaincode/ folder.

srderson commented 8 years ago

I think it should stay with the asset management chaincode. I'll try to figure out how to make the UTXO chaincode test case not break. That's the only reason we have the documentation to exclude the examples/ folder.

muralisrini commented 8 years ago

The entire .../asset_management/* is a test for ACL with chaincode and is standalone. Why would we not run it as part of unit tests ?

muralisrini commented 8 years ago

I think I misunderstood @srderson comment... if we can arrange it so we don't exclude examples/ from unit tests, then, the asset_management test case (rightly) belongs where it is.

christo4ferris commented 8 years ago

personally, I think that 'examples' is an awful name for chaincode that we use for tests. We should have a test/artifacts tree for that and examples should be exemplar code that is well documented and exhibits best practices. Sometimes, such as with chaincode that exhibits nondeterminism for purposes of ensuring that such chaincode is flagged, etc we will have bad practices and we don't want users emulating this sort of code.