[AES-CBC] Add some standard/recommended NIST tests for AES256

hyperledger-archives / fabric

THIS IS A READ-ONLY historic repository. Current development is at https://gerrit.hyperledger.org/r/#/admin/projects/fabric . pull requests not accepted

https://gerrit.hyperledger.org/

Apache License 2.0

1.17k stars 1.01k forks source link

[AES-CBC] Add some standard/recommended NIST tests for AES256 #2167

Open JonathanLevi opened 8 years ago

JonathanLevi commented 8 years ago

Description

While our core/crypto/primitives has a pair of PKCS7Padding and PKCS7UnPadding which is used extensively. We want to add more unit tests to lock/document and verify their correct/expected/standard/compliant behavior.

In particular, test using a few recommended test-vectors which NIST recommended and some of these variants.

This is part of #2127 Add a family of AES-CBC related tests

Describe How to Reproduce

N/A. Should be covered in the future by make unit-test

sudeepta-bhuyan commented 8 years ago

Hi @JonathanLevi , I can take this up (with some help) Sudeepta

JonathanLevi commented 8 years ago

Hi @sudeepta-bhuyan as per our chat on Slack, this item has some internal dependencies, etc... as in order to get these in we are working on refactoring the underlying package.

So, thanks again, and we'll discuss some others items/issues next week!