hyperledger-archives / fabric

THIS IS A READ-ONLY historic repository. Current development is at https://gerrit.hyperledger.org/r/#/admin/projects/fabric . pull requests not accepted
https://gerrit.hyperledger.org/
Apache License 2.0
1.17k stars 1.01k forks source link

Why is openjdk-8-jdk being installed from ppa:openjdk-r/ppa? #2215

Open s390xlinux opened 8 years ago

s390xlinux commented 8 years ago

Description

In ./scripts/provision/docker.sh (and also ./scripts/provision/host.sh), openjdk-8-jdk is being installed from ppa:openjdk-r/ppa. This break fabric-baseimage creation on zLinux because launchpad has no corresponding package for s390x:

Step 13 : RUN add-apt-repository ppa:openjdk-r/ppa -y
 ---> Running in d2a4dfc884d3
gpg: keyring `/tmp/tmp_bdba831/secring.gpg' created
gpg: keyring `/tmp/tmp_bdba831/pubring.gpg' created
gpg: requesting key 86F44E2A from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp_bdba831/trustdb.gpg: trustdb created
gpg: key 86F44E2A: public key "Launchpad OpenJDK builds (all archs)" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
Warning: apt-key output should not be parsed (stdout is not a terminal)
OK
 ---> 77eb0eb5a758
Removing intermediate container d2a4dfc884d3
Step 14 : RUN apt-get update && apt-get install openjdk-8-jdk -y
 ---> Running in c647e127348c
Ign:1 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety InRelease
Hit:2 http://ftp-nyc.osuosl.org/debian sid InRelease
Ign:3 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety Release
Ign:4 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main s390x Packages
Ign:5 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main all Packages
Ign:6 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main Translation-en
Ign:4 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main s390x Packages
Ign:5 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main all Packages
Ign:6 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main Translation-en
Ign:4 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main s390x Packages
Ign:5 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main all Packages
Ign:6 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main Translation-en
Ign:4 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main s390x Packages
Ign:5 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main all Packages
Ign:6 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main Translation-en
Ign:4 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main s390x Packages
Ign:5 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main all Packages
Ign:6 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main Translation-en
Err:4 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main s390x Packages
  404  Not Found
Ign:5 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main all Packages
Ign:6 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety/main Translation-en
Reading package lists...
W: The repository 'http://ppa.launchpad.net/openjdk-r/ppa/ubuntu yakkety Release' does not have a Release file.
E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/yakkety/main/binary-s390x/Packages  404  Not Found
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command '/bin/sh -c apt-get update && apt-get install openjdk-8-jdk -y' returned a non-zero code: 100
Makefile:145: recipe for target 'build/image/base/.dummy' failed
make: *** [build/image/base/.dummy] Error 1

Ubuntu/Debian already has openjdk-8-jdk in its main repository. Why are we using launchpad?

Describe How to Reproduce

make images

GrapeBaBa commented 8 years ago

are you sure?i cannot install openjdk8 directly on Ubuntu 14.04

s390xlinux commented 8 years ago

Why use 14.04 when 16.04 has been out for 3 months now?

GrapeBaBa commented 8 years ago

but vagrant env currently use 14.04, so the question actually if fabric can use 16.04 for vagrant env😀

s390xlinux commented 8 years ago

I don't see why not. Only way to find out is try. :-)

ghaskins commented 8 years ago

The devenv simply predates the 16.04 release and we have lacked bandwidth to qualify it. If someone wants to take this on, I would love to see the PR.