search

hyperledger-archives / fabric

THIS IS A READ-ONLY historic repository. Current development is at https://gerrit.hyperledger.org/r/#/admin/projects/fabric . pull requests not accepted
https://gerrit.hyperledger.org/
Apache License 2.0
1.17k stars 1.01k forks source link

Have you check the security (tcert) before you put a transaction message into the consenter? #2388

Open CocoaWang opened 8 years ago

CocoaWang commented 8 years ago

Description

When I deploy a transaction,I find it goes to ProcessTransactionMsg in engine.go. And in there,I see these words. // Chaincode Transaction response = &pb.Response{Status: pb.Response_SUCCESS, Msg: []byte(tx.Uuid)} //TODO: Do we need to verify security, or can we supply a flag on the invoke ot this functions // If we fail to marshal or verify the tx, don't send it to consensus plugin if response.Status == pb.Response_FAILURE { return response } Does this means that the vp does not verify security and puts the transaction message directly into the consenter?I just don't know when the vp check the transaction's legitimacy. Thanks!

Describe How to Reproduce

christo4ferris commented 8 years ago

@CocoaWang we have transitioned issue tracking to Jira https://jira.hyperledger.org/. Please transfer this issue there. Thank you!

CocoaWang commented 8 years ago

@christo4ferris I just registered a new user in Jira ,but I can't login in successfully.

christo4ferris commented 8 years ago

@CocoaWang you need an LF ID to login to Jira and Gerrit: https://identity.linuxfoundation.org/