search

hyperledger-archives / fabric

THIS IS A READ-ONLY historic repository. Current development is at https://gerrit.hyperledger.org/r/#/admin/projects/fabric . pull requests not accepted
https://gerrit.hyperledger.org/
Apache License 2.0
1.17k stars 1.01k forks source link

Message Enum doesn't allow for expandability #2395

Open ruslan-ardashev opened 8 years ago

ruslan-ardashev commented 8 years ago

Description

The Message enum as defined in the protocol spec doesn't support future development (i.e. instead of spacing out enum values they're grouped together).

This will pose code consistency and readability issues in the near future when expanding on existing Message types (e.g. try adding a new kind of Discovery Message).

christo4ferris commented 8 years ago

@ruslan120101 we've migrated to using Jira for issue tracking, please open an issue there and close this one. You'll need a Linux Foundation ID to login. Thanks