search

hyperledger-archives / indy-sdk

indy-sdk
https://wiki.hyperledger.org/display/indy
Apache License 2.0
669 stars 735 forks source link

fix ordering of attributes being used before being introduced #2432

Closed AxelNennker closed 9 months ago

AxelNennker commented 3 years ago

Signed-off-by: Axel Nennker axel.nennker@telekom.de

The compiler was complaining about the following:

warning: derive helper attribute is used before it is introduced --> src/services/pool/types.rs:357:3 357 #[serde(tag = "op")] ^^^^^ 358 #[derive(Serialize, Deserialize, Debug)] --------- the attribute is introduced here

= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79202 https://github.com/rust-lang/rust/issues/79202

This PR reorders the two code lines so that the attribute is used after being introduced

AxelNennker commented 3 years ago

I think the build failure is not due to this PR.

WadeBarnes commented 2 years ago

@AxelNennker, you are correct, it is not. A fix for the build issues has been implemented (#2470), which should have also addressed the changes you made here. Please confirm and close the PR is this is the case.