search

hyperledger-archives / indy-sdk

indy-sdk
https://wiki.hyperledger.org/display/indy
Apache License 2.0
669 stars 735 forks source link

docs: Update getting started dockerfile #2438

Closed rach-id closed 9 months ago

rach-id commented 3 years ago

Ubuntu 16.04 still installs Python:2.7 and pip. Thus, the getting-started docker image doesn't build as expected. So, an update to Ubuntu:20.04 is needed for the images to build successfully.

dlz21 commented 2 years ago

This fixes build error, how can we get someone to look at this?

rach-id commented 2 years ago

If someone is interested in merging this, I can fix the pipelines :D

WadeBarnes commented 2 years ago

@SweeXordious, You need to add DCO sign-off to your commits. Details here; https://github.com/hyperledger/indy-sdk/pull/2438/checks?check_run_id=4056269767

rach-id commented 2 years ago

@WadeBarnes Can you please let me know why the CI is not passing ? I don't have access to jenkins

WadeBarnes commented 2 years ago

@WadeBarnes Can you please let me know why the CI is not passing ? I don't have access to jenkins

It's a rust (cargo) version issue that is failing the builds. https://github.com/hyperledger/indy-sdk/pull/2452#issuecomment-988177968

More specifically; https://github.com/hyperledger/indy-sdk/issues/2460

rach-id commented 2 years ago

Thanks, will wait until it's fixed then rebase

WadeBarnes commented 2 years ago

A fix for the build issues has been implemented (https://github.com/hyperledger/indy-sdk/pull/2470). Please rebase this PR on the latest from the main branch so it is no longer blocked by the related build issues.

WadeBarnes commented 2 years ago

@SweeXordious, Sorry, it looks like the merge from another PR has created a conflict with your change. Could you please review.

rach-id commented 2 years ago

@WadeBarnes Thanks for letting me know. Conflicts resolved.