search

hyperledger-archives / indy-sdk

indy-sdk
https://wiki.hyperledger.org/display/indy
Apache License 2.0
668 stars 736 forks source link

Update indy-walkthrough.md #2462

Closed meadoch1 closed 9 months ago

meadoch1 commented 2 years ago

This work changes "Trust Anchor" to "Endorser" to align with the changes in 79aed586c586da8d47adb423ff3f7dcbf31fcb22

meadoch1 commented 2 years ago

The SHA referenced is in indy-node. https://github.com/hyperledger/indy-node/commit/79aed586c586da8d47adb423ff3f7dcbf31fcb22#diff-2088d14bfcb85060b0b7a97ab31573a39e6fcfba76804d1c27194fc6cea46379

WadeBarnes commented 2 years ago

Thanks @meadoch1. Could you add the required DCO sign-off to your commit please. Details here; https://github.com/hyperledger/indy-sdk/pull/2462/checks?check_run_id=4817377128

meadoch1 commented 2 years ago

Done. Sorry for the misstep. I did the work via Github's editor and didn't think about a doc update triggering other checks. Will be more mindful in the future.

WadeBarnes commented 2 years ago

Thanks

WadeBarnes commented 2 years ago

@meadoch1, I've fixed the issues causing the Jenkins builds to fail (https://github.com/hyperledger/indy-sdk/pull/2470). If you rebase your PR on the latest from the main branch the builds should work and we can get your PR merged. I know this is just a documentation update, but the builds passing is a gate to allow the PR to be merged.