search

hyperledger-archives / indy-sdk

indy-sdk
https://wiki.hyperledger.org/display/indy
Apache License 2.0
668 stars 735 forks source link

Android build.sh always uses arm dependencies when downloading pre-built #948

Closed kchan628 closed 6 years ago

kchan628 commented 6 years ago

https://github.com/hyperledger/indy-sdk/blob/f58e5fde80b71f0dc99ee60ad86c8b3634f8e341/libindy/build_scripts/android/build.sh#L28

should be

    export OPENSSL_DIR=dependencies/openssl/openssl_${TARGET_ARCH}
    export SODIUM_DIR=dependencies/sodium/libsodium_${TARGET_ARCH}
    export LIBZMQ_DIR=dependencies/zmq/libzmq_${TARGET_ARCH}
AxelNennker commented 6 years ago

Seems to make sense. The error does not happen when the directories are cleared between building platforms which was previously the case, I think. @faisal00813

faisal00813 commented 6 years ago

It should be openssl_${TARGET_ARCH} @kchan628 Thank you for reporting.

faisal00813 commented 6 years ago

PR for the fix https://github.com/hyperledger/indy-sdk/pull/950

faisal00813 commented 6 years ago

Fix is in master now.

faisal00813 commented 6 years ago

@kchan628 @jovfer Can we close this issue now, since the fix is in master?