hyperledger-archives / iroha

Iroha - A simple, decentralized ledger
http://iroha.tech
Apache License 2.0
988 stars 298 forks source link

Adding a link for PRs from forks into CONTRIBUTING.md #2093

Closed LiraLemur closed 5 years ago

LiraLemur commented 5 years ago

Signed-off-by: Sara lira.lemur@gmail.com

Description of the Change

Just adding a small link

Benefits

Some contributors might find the linked instructions useful

Possible Drawbacks

none

neewy commented 5 years ago

@BulatSaif do we need to trigger CI for docs? I think that in this case we can put some tags in commits, in order not to trigger CI…

BulatSaif commented 5 years ago

@neewy , which docs are you mean?

  1. https://iroha.readthedocs.io/en/master/
    or
  2. https://docs.iroha.tech/

1- is separate service, do not triggered from CI 2- our service, can be trigger by request in new CI, by default it is trigger only for master and develop

LiraLemur commented 5 years ago
  1. https://docs.iroha.tech/

I was not aware we even had that O_o @BulatSaif This PR is about the first one. It builds the docs from here: https://github.com/hyperledger/iroha/tree/master/docs thus triggering the CI

BulatSaif commented 5 years ago

Now I understand. Yes, we can skip CI if only iroha/docs/ or *.md files are changed. @neewy, please, can you create the task for that

neewy commented 5 years ago

@BulatSaif yes <3