RC4 Hotfix 1 - TemporaryWsv deadlock, checkTxPresence performance - Githubissues

hyperledger-archives / iroha

Iroha - A simple, decentralized ledger

http://iroha.tech

Apache License 2.0

988 stars 298 forks source link

RC4 Hotfix 1 - TemporaryWsv deadlock, checkTxPresence performance #2140

Closed lebdron closed 5 years ago

lebdron commented 5 years ago

Description of the Change

Add rollback before TemporaryWsv creation to prevent a deadlock in reject case, if a block was prepared before voting
Add hash index for transaction status table to prevent sequential scan on each query

Benefits

Improved performance

Possible Drawbacks

One more query in the pipeline, hash index is not WAL logged

Usage Examples or Tests

PreparedBlockTest.TemporaryWsvUnlocks

Alternate Designs

Use btree instead of hash index