search

hyperledger-archives / iroha

Iroha - A simple, decentralized ledger
http://iroha.tech
Apache License 2.0
988 stars 298 forks source link

Build: disable non-empty variadic macro arguments requirement #2201

Closed MBoldyrev closed 5 years ago

MBoldyrev commented 5 years ago

Description of the Change

For some reason apple clang now acts as if it had -Wgnu-zero-variadic-macro-arguments enabled by default. https://jenkins.soramitsu.co.jp/blue/organizations/jenkins/iroha%2Firoha-hyperledger-old/detail/develop/442/pipeline

[2019-03-27T05:50:28.169Z] /Users/jenkins/workspace/ha_iroha-hyperledger-old_develop/test/module/shared_model/backend_proto/permissions_test.cpp:61:43: error: must specify at least one argument for '...' parameter of variadic macro [-Werror,-Wgnu-zero-variadic-macro-arguments]
[2019-03-27T05:50:28.169Z] TYPED_TEST_CASE(ProtoPermission, PermTypes);
[2019-03-27T05:50:28.169Z]                                           ^
[2019-03-27T05:50:28.169Z] /usr/local/deps/gtest/include/gtest/gtest-typed-test.h:194:10: note: macro 'TYPED_TEST_CASE' defined here
[2019-03-27T05:50:28.169Z] # define TYPED_TEST_CASE(CaseName, Types, ...)                             \
[2019-03-27T05:50:28.170Z]          ^

This fix disables it explicitly.

Benefits

Hopefully CI will be able to build develop.

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

lebdron commented 5 years ago

Does not seem required since develop builds successfully without any changes at the moment.